Page MenuHomePhabricator

Feature detection, mbstring
Open, NormalPublic

Description

Affects rSF

Apparently, the the database system in Spitfire requires php-mbstring to work, but does not properly fail if the system does not have it.
The following error:

There was 1 error:

1) tests\spitfire\io\CharsetEncoderTest::testEncoder
Error: Call to undefined function spitfire\io\mb_convert_encoding()

/home/cesar/NetBeansProjects/spitfire/io/CharsetEncoder.php:44
/home/cesar/NetBeansProjects/spitfire/tests/io/CharsetEncoderTest.php:14

Is rather cryptic and does not indicate that the application needs mbstring to work. Instead it makes the issue look like it's an improperly namespaced function.

This bug somewhat overlaps with the work I'm doing on T21 - my suggestion would be to indicate to the user that they should execute the appropriate utility, which could also make use of the work on T42 to provide a nice error message - especially on the CLI side.

Event Timeline

cesar created this task.Oct 24 2019, 8:32 AM
cesar created this object with visibility "Public (No Login Required)".
cesar added parent tasks: T42: Handle different error types with different error pages, Unknown Object (Maniphest Task).
cesar removed parent tasks: Unknown Object (Maniphest Task), T42: Handle different error types with different error pages.
cesar triaged this task as Normal priority.Oct 24 2019, 8:35 AM
cesar added subtasks: T42: Handle different error types with different error pages, Unknown Object (Maniphest Task).
cesar closed subtask Unknown Object (Maniphest Task) as Resolved.May 27 2020, 4:13 PM