Page MenuHomePhabricator

Open Tasks

Active Repositories

Recent Activity

Today

cesar closed D657: Added phpstan.
Tue, May 11, 4:27 PM
cesar committed rSFDEFEReb88b65a350b: Added phpstan (authored by cesar).
Added phpstan
Tue, May 11, 4:27 PM
cesar updated the diff for D657: Added phpstan.

Rebased master into D657

Tue, May 11, 4:27 PM
cesar accepted D657: Added phpstan.
Tue, May 11, 4:24 PM
cesar committed R67:21da747f4fa8: Made the SDK depend on phpauth (authored by cesar).
Made the SDK depend on phpauth
Tue, May 11, 2:41 PM
cesar requested review of D766: PHPStan is now happy about the validation. PHPUnit too.
Tue, May 11, 1:53 PM
cesar closed D656: Works for phpstan now.
Tue, May 11, 12:01 PM
cesar committed rSFCACHEf27862632ecd: Works for phpstan now (authored by cesar).
Works for phpstan now
Tue, May 11, 12:01 PM
cesar accepted D656: Works for phpstan now.

Tests are passing just fine!

Tue, May 11, 12:01 PM
cesar closed D655: Added phpstan.
Tue, May 11, 10:54 AM
cesar committed rBILLSDKPHP5653e6bbcc91: Added phpstan (authored by cesar).
Added phpstan
Tue, May 11, 10:54 AM
cesar accepted D655: Added phpstan.
Tue, May 11, 10:53 AM
cesar added a comment to D655: Added phpstan.

I'm going to land this in the pitiful state it is right now. Because phpstan is working as intended, which will allow us to rebase D401 and see if we can leverage phpstan to fix that mess.

Tue, May 11, 10:53 AM
cesar updated the diff for D655: Added phpstan.
  • removed the tests.sh file, which seems not to be doing anything rn
Tue, May 11, 10:52 AM
cesar closed D492: Removed issues reported by phpstan.
Tue, May 11, 10:48 AM
cesar committed rSFCOLLf18a6eeab0ec: Removed issues reported by phpstan (authored by cesar).
Removed issues reported by phpstan
Tue, May 11, 10:48 AM
cesar accepted D492: Removed issues reported by phpstan.

Everything is working as expected here.

Tue, May 11, 10:47 AM
cesar closed D653: Added PHPStan.
Tue, May 11, 10:46 AM
cesar committed R57:d31ef2a7869a: Added PHPStan (authored by cesar).
Added PHPStan
Tue, May 11, 10:46 AM
cesar accepted D653: Added PHPStan.
Tue, May 11, 10:46 AM
cesar added a comment to D653: Added PHPStan.

There's a minor issue with the fact that the Request's post Method is currently not accepting CurlFile as a parameter (at least according to the doc). I need to fix that in rREQUEST

Tue, May 11, 10:46 AM
cesar updated the diff for D653: Added PHPStan.
  • Expiration of refresh tokens can be null
Tue, May 11, 10:45 AM
cesar updated the diff for D653: Added PHPStan.
  • Documenting the parameters
  • Documenting the classes
Tue, May 11, 10:44 AM
cesar closed D652: phpstan.
Tue, May 11, 9:03 AM
cesar committed rREQUESTaf5e19d2fbc2: phpstan (authored by cesar).
phpstan
Tue, May 11, 9:03 AM
cesar accepted D652: phpstan.
Tue, May 11, 9:03 AM
cesar closed D651: phpstan improvements.
Tue, May 11, 9:00 AM
cesar committed R51:9dcbe04314ed: phpstan improvements (authored by cesar).
phpstan improvements
Tue, May 11, 9:00 AM
cesar accepted D651: phpstan improvements.
Tue, May 11, 9:00 AM
cesar closed D650: phpstan.
Tue, May 11, 8:57 AM
cesar committed rSWITCH0e825344dafc: phpstan (authored by cesar).
phpstan
Tue, May 11, 8:57 AM
cesar updated the diff for D650: phpstan.

Rebasing master. Sadly this leads to the destruction of the composer.lock file since
it's not locked to a certain version of permission-sdk, which causes issues.

Tue, May 11, 8:57 AM
cesar accepted D650: phpstan.
Tue, May 11, 8:53 AM
cesar closed D649: phpstan.
Tue, May 11, 8:51 AM
cesar committed rFIG6e7c8b47de17: phpstan (authored by cesar).
phpstan
Tue, May 11, 8:51 AM
cesar accepted D649: phpstan.
Tue, May 11, 8:51 AM

Yesterday

cesar closed D645: phpstan.
Mon, May 10, 5:02 PM
cesar committed rPERMc413fa7e4f75: phpstan (authored by cesar).
phpstan
Mon, May 10, 5:02 PM
cesar accepted D645: phpstan.
Mon, May 10, 5:00 PM
cesar updated the diff for D730: Move the schema from the dtaabse to the model.
  • Refactoring the schema to make it more testable without making the code horribly more verbose
Mon, May 10, 1:34 PM