Page MenuHomePhabricator

Code refactoring
ClosedPublic

Authored by cesar on Jan 5 2021, 9:22 AM.

Details

Test Plan

composer test should succeed

Diff Detail

Repository
R48 permission-php-sdk
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cesar requested review of this revision.Jan 5 2021, 9:22 AM
cesar created this revision.
This revision is now accepted and ready to land.Jan 5 2021, 9:40 AM
  • Updated the query mechanism
  • Missing typehint
  • Defined the array shapes

Needs some adjustments

.phpcs.xml
4

Here we should properly name our coding standard

6–12

Most of these directories do not exist in a SDK package like this one

composer.json
21

Here we should try to track a specific version, so the application works better

  • Making some adjustments
  • Removed the lint issues we had
This revision is now accepted and ready to land.Jun 9 2021, 2:00 PM
This revision was automatically updated to reflect the committed changes.