Page MenuHomePhabricator

Introducing PHPStan
ClosedPublic

Authored by cesar on Mar 29 2021, 1:19 PM.

Details

Summary

Ping is currently a bad candidate for introducing PHPStan. It has a ton of errors that
are inherently rooted in the framework and that are difficult to solve.

BUT, using the baseline feature we should at least prevent the code from getting any
worse from here on.

Test Plan

composer test should run fine

Diff Detail

Repository
R2 Ping
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cesar requested review of this revision.Mar 29 2021, 1:19 PM
cesar created this revision.
This revision is now accepted and ready to land.May 9 2021, 12:30 PM
This revision was automatically updated to reflect the committed changes.