Page MenuHomePhabricator

cesar (Cesar de la Cal Bretschneider)
EngineeringAdministrator

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 9 2019, 1:02 PM (96 w, 1 h)
Roles
Administrator
Availability
Available

Recent Activity

Today

cesar requested review of D766: PHPStan is now happy about the validation. PHPUnit too.
Tue, May 11, 1:53 PM
cesar closed D656: Works for phpstan now.
Tue, May 11, 12:01 PM
cesar committed rSFCACHEf27862632ecd: Works for phpstan now (authored by cesar).
Works for phpstan now
Tue, May 11, 12:01 PM
cesar accepted D656: Works for phpstan now.

Tests are passing just fine!

Tue, May 11, 12:01 PM
cesar closed D655: Added phpstan.
Tue, May 11, 10:54 AM
cesar committed rBILLSDKPHP5653e6bbcc91: Added phpstan (authored by cesar).
Added phpstan
Tue, May 11, 10:54 AM
cesar accepted D655: Added phpstan.
Tue, May 11, 10:53 AM
cesar added a comment to D655: Added phpstan.

I'm going to land this in the pitiful state it is right now. Because phpstan is working as intended, which will allow us to rebase D401 and see if we can leverage phpstan to fix that mess.

Tue, May 11, 10:53 AM
cesar updated the diff for D655: Added phpstan.
  • removed the tests.sh file, which seems not to be doing anything rn
Tue, May 11, 10:52 AM
cesar closed D492: Removed issues reported by phpstan.
Tue, May 11, 10:48 AM
cesar committed rSFCOLLf18a6eeab0ec: Removed issues reported by phpstan (authored by cesar).
Removed issues reported by phpstan
Tue, May 11, 10:48 AM
cesar accepted D492: Removed issues reported by phpstan.

Everything is working as expected here.

Tue, May 11, 10:47 AM
cesar closed D653: Added PHPStan.
Tue, May 11, 10:46 AM
cesar committed R57:d31ef2a7869a: Added PHPStan (authored by cesar).
Added PHPStan
Tue, May 11, 10:46 AM
cesar accepted D653: Added PHPStan.
Tue, May 11, 10:46 AM
cesar added a comment to D653: Added PHPStan.

There's a minor issue with the fact that the Request's post Method is currently not accepting CurlFile as a parameter (at least according to the doc). I need to fix that in rREQUEST

Tue, May 11, 10:46 AM
cesar updated the diff for D653: Added PHPStan.
  • Expiration of refresh tokens can be null
Tue, May 11, 10:45 AM
cesar updated the diff for D653: Added PHPStan.
  • Documenting the parameters
  • Documenting the classes
Tue, May 11, 10:44 AM
cesar closed D652: phpstan.
Tue, May 11, 9:03 AM
cesar committed rREQUESTaf5e19d2fbc2: phpstan (authored by cesar).
phpstan
Tue, May 11, 9:03 AM
cesar accepted D652: phpstan.
Tue, May 11, 9:03 AM
cesar closed D651: phpstan improvements.
Tue, May 11, 9:00 AM
cesar committed R51:9dcbe04314ed: phpstan improvements (authored by cesar).
phpstan improvements
Tue, May 11, 9:00 AM
cesar accepted D651: phpstan improvements.
Tue, May 11, 9:00 AM
cesar closed D650: phpstan.
Tue, May 11, 8:57 AM
cesar committed rSWITCH0e825344dafc: phpstan (authored by cesar).
phpstan
Tue, May 11, 8:57 AM
cesar updated the diff for D650: phpstan.

Rebasing master. Sadly this leads to the destruction of the composer.lock file since
it's not locked to a certain version of permission-sdk, which causes issues.

Tue, May 11, 8:57 AM
cesar accepted D650: phpstan.
Tue, May 11, 8:53 AM
cesar closed D649: phpstan.
Tue, May 11, 8:51 AM
cesar committed rFIG6e7c8b47de17: phpstan (authored by cesar).
phpstan
Tue, May 11, 8:51 AM
cesar accepted D649: phpstan.
Tue, May 11, 8:51 AM

Yesterday

cesar closed D645: phpstan.
Mon, May 10, 5:02 PM
cesar committed rPERMc413fa7e4f75: phpstan (authored by cesar).
phpstan
Mon, May 10, 5:02 PM
cesar accepted D645: phpstan.
Mon, May 10, 5:00 PM
cesar updated the diff for D730: Move the schema from the dtaabse to the model.
  • Refactoring the schema to make it more testable without making the code horribly more verbose
Mon, May 10, 1:34 PM
cesar closed D643: Added phpstan.
Mon, May 10, 12:25 PM
cesar committed rCNAS4721cdb0b56a: Added phpstan (authored by cesar).
Added phpstan
Mon, May 10, 12:25 PM
cesar accepted D643: Added phpstan.
Mon, May 10, 12:25 PM
cesar closed D642: PHPSTAN.
Mon, May 10, 12:22 PM
cesar committed rLOOT467256fabbb4: PHPSTAN (authored by cesar).
PHPSTAN
Mon, May 10, 12:22 PM
cesar accepted D642: PHPSTAN.
Mon, May 10, 12:22 PM

Sun, May 9

cesar triaged T625: Chad: Remove libraries from the repository as Normal priority.
Sun, May 9, 12:49 PM · Commishes, Commishes: Copper
cesar closed D638: Introduced phpstan.
Sun, May 9, 12:45 PM
cesar committed R3:b505a39c6e21: Introduced phpstan (authored by cesar).
Introduced phpstan
Sun, May 9, 12:45 PM
cesar accepted D638: Introduced phpstan.

This doesn't really matter anymore. Since CH00k is basically abandonware at this point.

Sun, May 9, 12:44 PM
cesar closed D637: Introducing PHPStan.
Sun, May 9, 12:30 PM
cesar committed R2:7a0322ce3bd9: Introducing PHPStan (authored by cesar).
Introducing PHPStan
Sun, May 9, 12:30 PM
cesar accepted D637: Introducing PHPStan.
Sun, May 9, 12:30 PM
cesar closed D636: Removed deprecated methods that relied on makeSignature and therefore were broken.
Sun, May 9, 12:28 PM
cesar committed R57:ea5dfac24768: Removed deprecated methods that relied on makeSignature and therefore were… (authored by cesar).
Removed deprecated methods that relied on makeSignature and therefore were…
Sun, May 9, 12:28 PM
cesar accepted D636: Removed deprecated methods that relied on makeSignature and therefore were broken.
Sun, May 9, 12:28 PM

Fri, May 7

cesar closed D635: Overlays now default to being absolute.
Fri, May 7, 9:49 PM
cesar committed rOVERLAY32f2b1ba9682: Overlays now default to being absolute (authored by cesar).
Overlays now default to being absolute
Fri, May 7, 9:49 PM
cesar accepted D635: Overlays now default to being absolute.
Fri, May 7, 9:45 PM
cesar requested review of D765: Fixes an undefined variable issue.
Fri, May 7, 9:39 PM
cesar updated the diff for D635: Overlays now default to being absolute.
  • Removed vulnerability issue
Fri, May 7, 12:43 PM
cesar updated the diff for D635: Overlays now default to being absolute.
  • Removed dist file
  • Fixed package.json
  • Updated pacakge.json
Fri, May 7, 12:28 PM
cesar closed D634: Exports as a node module.
Fri, May 7, 12:23 PM
cesar committed rOVERLAY87815a7c78f0: Exports as a node module (authored by cesar).
Exports as a node module
Fri, May 7, 12:23 PM
cesar accepted D634: Exports as a node module.
Fri, May 7, 12:23 PM
cesar updated the diff for D635: Overlays now default to being absolute.
  • Fixed package.json
Fri, May 7, 12:21 PM
cesar added a parent task for T406: Permission: Add a resource/policy method (compiled permissions): Unknown Object (Maniphest Task).
Fri, May 7, 12:09 PM · Permission Server, Unknown Object (Project), Commishes: Copper
cesar renamed T406: Permission: Add a resource/policy method (compiled permissions) from Permission: Add a resource/policy method to Permission: Add a resource/policy method (compiled permissions).
Fri, May 7, 11:11 AM · Permission Server, Unknown Object (Project), Commishes: Copper
cesar added a subtask for T624: CRM: Fix permission / policy for all the components: T406: Permission: Add a resource/policy method (compiled permissions).
Fri, May 7, 11:11 AM · Commishes: Copper
cesar added a parent task for T406: Permission: Add a resource/policy method (compiled permissions): T624: CRM: Fix permission / policy for all the components.
Fri, May 7, 11:11 AM · Permission Server, Unknown Object (Project), Commishes: Copper
cesar triaged T624: CRM: Fix permission / policy for all the components as Normal priority.
Fri, May 7, 11:10 AM · Commishes: Copper
cesar committed R66:dd4f25a7f025: Upgraded to Spitfire requests (authored by cesar).
Upgraded to Spitfire requests
Fri, May 7, 9:44 AM
cesar closed D681: Now depends on stable versions of our libs.
Fri, May 7, 9:40 AM
cesar committed R57:f0d925a51901: Now depends on stable versions of our libs (authored by cesar).
Now depends on stable versions of our libs
Fri, May 7, 9:40 AM
cesar updated the diff for D681: Now depends on stable versions of our libs.

Rebase master into D681

Fri, May 7, 9:39 AM
cesar accepted D681: Now depends on stable versions of our libs.
Fri, May 7, 9:37 AM

Thu, May 6

cesar requested review of D762: Removing template locators.
Thu, May 6, 3:17 PM
cesar requested review of D761: Removed the layout.
Thu, May 6, 3:15 PM
cesar closed D633: Removed the deprecated view elements.
Thu, May 6, 12:58 PM
cesar committed rSF5feeb7b2b478: Removed the deprecated view elements (authored by cesar).
Removed the deprecated view elements
Thu, May 6, 12:58 PM
cesar updated the diff for D633: Removed the deprecated view elements.

Rebased master into D633

Thu, May 6, 12:58 PM
cesar accepted D633: Removed the deprecated view elements.

This paves the way for the template inheritance.

Thu, May 6, 12:57 PM
cesar requested review of D760: Moving from callbacks to promises.
Thu, May 6, 12:51 PM
cesar updated the diff for D561: Config: Initial prototype.
  • Added the env() function to access the environment data
Thu, May 6, 11:48 AM
cesar requested review of D759: Added logic to boot a kernel.
Thu, May 6, 11:33 AM
cesar planned changes to D755: Added bootstrapping mechanism, so kernels can define scripts that need to beexecuted before they run.

There's a bunch of issues here

Thu, May 6, 11:28 AM

Wed, May 5

cesar requested review of D758: Removes spitfire::enable.
Wed, May 5, 7:12 PM
cesar requested review of D757: Removes spitfire::fire.
Wed, May 5, 6:09 PM
cesar requested review of D756: Changed the code to make use of the new kernels and PSRs.
Wed, May 5, 6:04 PM
cesar requested review of D755: Added bootstrapping mechanism, so kernels can define scripts that need to beexecuted before they run.
Wed, May 5, 5:42 PM
cesar updated the diff for D561: Config: Initial prototype.

Added the build configuration director

Wed, May 5, 5:02 PM
cesar updated the diff for D597: Added a director service provider that registers commands.
  • Wrong namespace
Wed, May 5, 4:48 PM
cesar updated the diff for D597: Added a director service provider that registers commands.

Added build config director

Wed, May 5, 4:47 PM
cesar added a subtask for T623: PHPAS: Make create.app command: T446: PHPAS: Update to SF 2020.
Wed, May 5, 2:41 PM · Commishes, Commishes: Copper
cesar added a parent task for T446: PHPAS: Update to SF 2020: T623: PHPAS: Make create.app command.
Wed, May 5, 2:41 PM · Commishes: Copper, PHPAuthServer
cesar triaged T623: PHPAS: Make create.app command as Normal priority.
Wed, May 5, 2:41 PM · Commishes, Commishes: Copper
cesar closed D632: When a radio is clicked, it makes the parents that are listening for it change.
Wed, May 5, 1:07 PM
cesar committed R9:d10c403fe99b: When a radio is clicked, it makes the parents that are listening for it change (authored by cesar).
When a radio is clicked, it makes the parents that are listening for it change
Wed, May 5, 1:07 PM
cesar accepted D632: When a radio is clicked, it makes the parents that are listening for it change.
Wed, May 5, 1:07 PM
cesar abandoned D631: Bumped url reflection to stable version.

A more advanced version of this is already in the repos

Wed, May 5, 12:16 PM
cesar accepted D631: Bumped url reflection to stable version.
Wed, May 5, 12:15 PM
cesar updated the diff for D754: Failure exception properly implements public exceptions now.
  • Bumped the packages to a reasonable position
Wed, May 5, 12:14 PM
cesar closed D659: phpstan.
Wed, May 5, 12:11 PM
cesar committed rSFAST30455dc1a9eb: phpstan (authored by cesar).
phpstan
Wed, May 5, 12:11 PM
cesar accepted D659: phpstan.
Wed, May 5, 12:11 PM